Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Add ardupilot_gazebo install script #22598

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

snktshrma
Copy link
Contributor

Added ardupilot_gazebo package for simulation purposes

Added ardupilot_gazebo package for simulation purposes
Tools/environment_install/install-ROS-ubuntu.sh Outdated Show resolved Hide resolved
@rmackay9
Copy link
Contributor

rmackay9 commented Jan 6, 2023

Thanks for this! I've asked @jmachuca77 and @srmainwaring for their review too.

Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this need more than this as the plugin got some dependancies to build

@snktshrma
Copy link
Contributor Author

@khancyr I have made the required changes and most of the dependencies will be downloaded while downloading and setting ardupilot.

@snktshrma snktshrma requested review from rmackay9 and khancyr and removed request for jmachuca77, srmainwaring, rmackay9 and khancyr January 6, 2023 10:20
@rmackay9 rmackay9 dismissed their stale review January 6, 2023 12:02

My requested changes have been made, thanks!

@rmackay9 rmackay9 merged commit 20550d4 into ArduPilot:master Jan 6, 2023
@rmackay9
Copy link
Contributor

rmackay9 commented Jan 6, 2023

Merged, thanks!


if maybe_prompt_user "Add ardupilot_gazebo to your home folder [N/y]?" ; then
if [ ! -d $AP_GZ_ROOT ]; then
sudo apt install libgz-sim7-dev rapidjson-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudo apt install gz-garden rapidjson-dev is needed to install all the libraries. See https://gazebosim.org/docs/garden/install_ubuntu.

sudo apt install libgz-sim7-dev rapidjson-dev
git clone https://github.com/ArduPilot/ardupilot_gazebo
pushd $AP_GZ_ROOT
mkdir build && pushd build
Copy link
Contributor

@srmainwaring srmainwaring Jan 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to create the workspace directory first, then clone, then cd into the project, then make build dir and build.

mkdir -p $AP_GZ_ROOT/src
pushd $AP_GZ_ROOT/src
git clone https://github.com/ArduPilot/ardupilot_gazebo
pushd ardupilot_gazebo
mkdir build && pushd build

Suggest that AP_GZ_ROOT has value ardupilot_gz_ws to distinguish from the project. Also, we should clone into $AP_GZ_ROOT/src so we can switch to using colcon for the build and install which is consistent with how Gazebo Sim and ROS2 are built (ardupilot_gazebo docs need to be updated to use this approach as well).

@srmainwaring
Copy link
Contributor

srmainwaring commented Jan 7, 2023

@rmackay9 - only had a chance to look at this. There are a few issues with the script I'm afraid. I've started to add notes but hit a couple of snags with the script for Ubuntu 20.04 / ROS Noetic which I'm documenting in #22484.

We may also hit some issues with a desktop-full install of ROS1 which uses catkin and Gazebo11 and the plugin build which targets Gazebo Sim uses colcon. They should co-exist but I'm seeing a couple of package dependency issues for the ROS1 install when I rerun the script after installing gz-garden...

@rmackay9
Copy link
Contributor

rmackay9 commented Jan 9, 2023

@srmainwaring,

Thanks very much for reviewing this. Sorry I merged this too quickly. I don't really understand this all that well so from now on I might hold off on merging PRs in this area until you've had a chance to review. Thanks again!

@snktshrma
Copy link
Contributor Author

snktshrma commented Jan 9, 2023

Hi! Earlier I was working with Khancyr's and SwiftGust's version of ardupilot_gazebo package and these instructions were working pretty fine! Probably the issue arose after shifting to ardupilot's version of ardupilot_gazebo.

Anyhow, thanks for these changes @srmainwaring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants